Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onnxruntime/build] Add new flag enable_generic_interface to build primary EPs by default #23342

Merged
merged 26 commits into from
Jan 28, 2025

Conversation

karim-vad
Copy link
Contributor

Description

  • Add new build flag in build.py to build onnxruntime.dll supporting interfaces for all primary EPs( QNN, TensoRT, OpenVino, VitisAI).
  • Modify onnxruntime.dll/onnxruntime_shared.dll build settings to remove dependency of IHV SDK Toolset to be installed on the system.
  • Change CMake variables to be explicit when building EP vs ORT. e.g. onnxruntime_USE_TENSORRT vs onnxruntime_USE_TENSORRT_INTERFACE, to evolve the build system to build ORT independent of EPs.

Motivation and Context

Changes in the build system required to evolve the repo to build the components independently while removing unnecessary dependencies

samples/GenericInterface/test.cpp Fixed Show fixed Hide fixed
tools/ci_build/build.py Fixed Show fixed Hide fixed
tools/ci_build/build.py Fixed Show fixed Hide fixed
tools/ci_build/build.py Outdated Show resolved Hide resolved
tools/ci_build/build.py Outdated Show resolved Hide resolved
@jslhcl jslhcl marked this pull request as draft January 13, 2025 22:05
tools/ci_build/build.py Fixed Show fixed Hide fixed
@karim-vad karim-vad marked this pull request as ready for review January 15, 2025 18:16
tools/ci_build/build.py Outdated Show resolved Hide resolved
snnn
snnn previously approved these changes Jan 22, 2025
tools/ci_build/build.py Outdated Show resolved Hide resolved
tools/ci_build/build.py Outdated Show resolved Hide resolved
onnxruntime/core/session/provider_bridge_ort.cc Outdated Show resolved Hide resolved
snnn
snnn previously approved these changes Jan 23, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit the suggested changes from lintrunner.

tools/ci_build/build.py Outdated Show resolved Hide resolved
karim-vad and others added 2 commits January 23, 2025 23:38
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@karim-vad
Copy link
Contributor Author

karim-vad commented Jan 28, 2025 via email

Copy link
Member

@snnn snnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@karim-vad karim-vad merged commit 655a23f into main Jan 28, 2025
100 checks passed
@karim-vad karim-vad deleted the dev/kvadsariya/wcr branch January 28, 2025 23:24
@adrianlizarraga
Copy link
Contributor

@karim-vad Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants